Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont publish .netcore temp nuget packages #1911

Merged
merged 1 commit into from
Sep 5, 2016
Merged

dont publish .netcore temp nuget packages #1911

merged 1 commit into from
Sep 5, 2016

Conversation

enricosada
Copy link
Collaborator

the PublishNuGet task now delete the temp dotnetcore nuget packages before paket push

tested locally and package list to publish is ok

        Could not push package e:\github\Paket\temp\Paket.PowerShell.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.
Paket failed with:
        Could not push package e:\github\Paket\temp\Paket.Core.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.
Paket version 3.19.0.0
Paket failed with:
        Could not push package e:\github\Paket\temp\Paket.3.19.0.nupkg due to missing credentials for the url https://nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the environment variable "nugetkey", or by using 'paket config add-token'.

and temp/dotnetcore nuget pkg are deleted

@enricosada enricosada mentioned this pull request Sep 5, 2016
Merged
8 tasks
@forki
Copy link
Member

forki commented Sep 5, 2016

.net restore failed. sigh

@forki forki merged commit 1f78cf5 into fsprojects:master Sep 5, 2016
@matthid
Copy link
Member

matthid commented Sep 5, 2016

how is paket push behavior defined? does it randomly choose the first matching nupkg it finds?

I think it should have errored out in this case withou pushung anything...

@enricosada
Copy link
Collaborator Author

enricosada commented Sep 5, 2016 •
edited
Loading

@matthid i think fake just it tried to pushing all packages and nuget.org used last package.

let packages = !! (parameters.WorkingDir @@ "/**/*.nupkg") |> Seq.toList

maybe a safety check on names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enricosada @forki @matthid