Change project file condition handling to be case-insensitive #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fails currently because output path detected does not match configuration name perfectly
`Project1.fsprojtest` specifies its output path as `bin\$(Configuration)\`, which means that the exact configuration passed in will be the result. However, the other test project files have hard-coded output paths. This handles both cases.
|
Uhh, soo, travis is out of disk space? |
Per @cloudRoutine, it's faster than InvariantCultureIgnoreCase is, and still makes this code case-insensitive.
|
I'm not sure with which person I have to sleep with to get this bigger. |
|
regarding mono build issue: travis-ci/travis-ci#6524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to fiddle with the test a bit because one of the test projects uses the given build configuration as part of its output path, but this should fix #1889.