Allow printing of version number through command-line option #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @eiriktsarpalis |
|
@forki LGTM |
ErikSchierboom
changed the title
|
I'll remove the [WIP] part from the title then. |
|
thanks! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in #1875, where you can specify the
--versionargument to print the version to the console. However, while implementing this, I found I had to remove theRequireSubcommandattribute, as--versionis (rightfully) not considered a sub-command and having theRequireSubcommandattribute would cause it to fail. The result of this change is of course that sub-commands are now not necessary, which I think is a bit odd. What do you think about this?The main problem is that #1875 suggests that the
--versionflags is used for displaying the version, but perhaps it should just be a regular subcommand?