Update: support combining filter with specific version #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: the matching logic seems somewhat risky to me, there is a chance for collisions with argument/option keywords. Isn't "nuget" required to be the first (index 0) and the package name the second token (index 1) for nuget dependencies, provided we specify |
|
yeah. can you fix that as well? |
…th dependency options
|
One integration test failed with a timed out ( |
|
probably not. that one is flaky. |
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update supports updating all packages matching a regex. It also supports providing a specific version to update to. What it did not support before is combining these two, i.e. updating all packages matching a regex to the same specific version. This PR adds the missing piece to support this combination.