Correct src folder structure for packing with symbols #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbosman
force-pushed
the
symbols-src-folders
branch
from
f9f0180
to
24378f8
Compare
kevinbosman
force-pushed
the
symbols-src-folders
branch
from
24378f8
to
0615c37
Compare
|
don't worry about the broken test. I'm playing with something |
|
Cool thanks, it was timing out on Travis only, so I kicked off another build... |
|
sorry didn't see that. there was indeed a broken test here. "#1538 symbols src folder structure" doesn't work on mono. could you please look again? |
|
Will do... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packing a NuGet package with symbols generates the incorrect src folder structure within the symbols.nupkg file, which prevents the source from being found when querying the symbolsource server.
This PR adds an integration test with a few examples in a new scenario, and fixes the problem.
The fixed symbols package has been tested to be working correctly on our local ProGet symbols server from Visual Studio 2015.