Restore: optional --touch-affected-refs to touch refs affected by a restore #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrnet
changed the title
cdrnet
force-pushed
the
touch-affected-project-files
branch
from
66a7601
to
b528ca4
Compare
cdrnet
changed the title
|
Project.touch sound s like a good change |
forki
added a commit
that referenced
this pull request
Feb 29, 2016
Restore: optional --touch-affected-refs to touch refs affected by a restore
forki
pushed a commit
that referenced
this pull request
Mar 1, 2016
… file content This is a follow up to #1485 which introduced the optional --touch-affected-refs parameter on restore. In the original implementation this caused the project file to be saved forcefully, which could in some cases cause the file content to change slightly (e.g. minor xml formatting). With this change, the only effect of --touch-affected-refs will be a modified last-write time file attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal how #1471 could be addressed, to help incremental build tools like MsBuild to detect the need to rebuild selective projects.
I'm not convinced
Project.save trueis the right approach though, since it could also affect the content of the project file. Maybe we should specifically add aProject.touchinstead which guarantees the project file content remains exactly the same?