-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed pack package dependencies for dependent projects #1417
Conversation
does it still exclude stuff that has it's own template file? |
no. I'll add that in now. |
Just noticed a problem with ProjectFile.findCorrespondingFile I think the indentation for findInDir is all wrong, and as a result, it never does that bit of searching. I can fix that, but is the purpose of that function to find the paket.template and paket.references files for the project? If so, should it actually be tree walking up the directory stack to find them? I would imagine that they should be present in the same directory only to be considered the associated file. |
ensured this cascaded recursively
Working in the following way.
I'd like to do a bit more testing before hitting go on this, but need to be able to sync up with my laptop. |
cool. let me know when you are ready |
should be ready. You may want to consider putting this into the 3.0 branch, as there's a breaking change What it does now do tho, is walk the project dependency tree recursively if that switch is set. It does it for dependencies, sources and dll's, which imho is an improvement of nuget, as it only goes one level down. |
but we never wanted to do this anyway, right? I mean we epected that this did not happen. Or am I wrong here? |
Direct project dlls had already been added, so my previous commit didn't change that behaviour. But you are correct, the behaviour in that commit is what we want. |
Sorry, this commit, is the correct behaviour. |
No edit on mobile. :-( |
thx |
can youn please send a PR for docs update? Thx |
the original commit had some document changes. Tho I'll add some extra wording to make sure it's clear that it's recursive, and that projects with their own project template files are ignored. |
Do we have the parameter documented? Where exactly?
|
right at the very end. |
hmm, can't find that in the solution any more. |
changed the doco around include-referenced-projects
fixed dependency resolution for project dependencies