Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect case sensitivity for package paths #137

Merged
merged 1 commit into from
Sep 20, 2014
Merged

Respect case sensitivity for package paths #137

merged 1 commit into from
Sep 20, 2014

Conversation

ilkerde
Copy link
Contributor

@ilkerde ilkerde commented Sep 20, 2014

This is a very quick fix for #108. I'm sorry I didn't supply tests, but I'm too much of a novice to easily extract addPackage and have tests for it. I built on Win7 and tested on Linux/Mono. Seems to work fine.

@forki
Copy link
Member

forki commented Sep 20, 2014

nice catch.

forki added a commit that referenced this pull request Sep 20, 2014
@forki
Merge pull request #137 from ilkerde/case-matters
09db8b2 
Respect case sensitivity for package paths
@forki forki merged commit 09db8b2 into fsprojects:master Sep 20, 2014
@ilkerde ilkerde deleted the case-matters branch September 20, 2014 17:34
@forki
Copy link
Member

forki commented Sep 20, 2014

this seems to break everybody else.

will investigate tommorrow

@ilkerde
Copy link
Contributor Author

ilkerde commented Sep 20, 2014

I'm very sorry. I the merged bin even on Win7 with Paket itself. Seems it was not enough.

@forki
Copy link
Member

forki commented Sep 20, 2014

I think I found it.

2014-09-20 20:11 GMT 02:00 ilkerde [email protected]:

I'm very sorry. I the merged bin even on Win7 with Paket itself. Seems
it was not enough.

—
Reply to this email directly or view it on GitHub
#137 (comment).

@forki
Copy link
Member

forki commented Sep 20, 2014

your fix was correct, but not enough.

2014-09-20 20:16 GMT 02:00 Steffen Forkmann [email protected]:

I think I found it.

2014-09-20 20:11 GMT 02:00 ilkerde [email protected]:

I'm very sorry. I the merged bin even on Win7 with Paket itself. Seems
it was not enough.

—
Reply to this email directly or view it on GitHub
#137 (comment).

@forki
Copy link
Member

forki commented Sep 20, 2014

could you please review and test fd2c58c ?

Thanks

@ilkerde
Copy link
Contributor Author

ilkerde commented Sep 20, 2014

Checked .26 on linux with 2 reference projects and Paket itself. All good with respect to package resolve and install. My mono build of Paket still fails (for good reason). But that's a different story.

@forki
Copy link
Member

forki commented Sep 20, 2014

Excellent. One bug down.
And it already helped at least one other person #133 (comment)
Thanks a lot

@bartelink
Copy link
Member

#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilkerde @forki @bartelink