Fixing problem with @ char in paths during pack (#1348) #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the travis fail is unrelated. |
|
|
||
| [<Test>] | ||
| let ``#1235 npm type folder names`` () = |
|
ok, good. Was scratching my head severely now |
|
Quick question, what is the logic behind the # 1234 type naming in the integration tests? I just did the above test number 1, but now I am starting to think it might be references to github issues? |
|
yep test name should be "#1348 ..." |
|
this allows us to find the issue from the test (when we break it in the future) |
|
fixing... |
|
fixed |
forki
added a commit
that referenced
this pull request
Jan 6, 2016
Fixing problem with @ char in paths during pack (#1348)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1348