Handle different platforms in ProjectFile.GetOutputPath #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added it everywhere that the compiler complained about, and added a new `buildplatform` option to the `paket pack` command to supply the new value.
If String.IsNullOrWhiteSpace returns true for the specified platform, then all of the platforms specified at the following MSDN article (as of now) are tested: https://msdn.microsoft.com/en-us/library/zekwfyz4.aspx If a platform is specified, that platform is tested.
|
something doesn't compile |
Forgot to specify an value when I added the `attempted` param to the `tryNextPlat` helper function.
|
Sorry; added a parameter to my helper function and then forgot to pass it a value. |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
buildplatformoption to thepaket packcommand and sprinkled it lovingly throughout the codebase anywhere the compiler complained loudly enough.ProjectFile.GetOutputPathnow attempts to evaluate the project file for theOutputPathvalue given the specified platform. If no platform is specified, runs through a list of platforms until one of them works or the list becomes empty.Given how
ProjectFile.GetPropertyWithDefaultsis currently written, these platform values look like they'll be case-sensitive, but this could easily be changed if needed.cc/ @agross: If you have a few minutes, can you see if this resolves #1262?