Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to force Nuget source and use local file paths with bootstrapper #1268

Merged
merged 7 commits into from
Dec 1, 2015
Merged

Add options to force Nuget source and use local file paths with bootstrapper #1268

merged 7 commits into from
Dec 1, 2015

Conversation

allykzam
Copy link
Contributor

Added a --force-nuget command-line argument to the bootstrapper to get paket.exe from nuget rather than github, and to not automatically fallback to github as the --prefer-nuget option does. Did this by just setting the FallbackStrategy to null, as the bootstrapper appears to already handle that here.

Additional changes coming to allow using a local file path for the nuget source specified with --nuget-source, rather than a web API.

If true, the Nuget download strategy is used, and no fallback strategy
is provided; ignores the value of preferNuget. If false, continues
existing evaluation, checking the preferNuget parameter.
If the `--force-nuget` command-line argument is supplied, or the
`ForceNuget` setting exists in the application settings and is set to
`true`, then the download strategy is set to only use the specified
Nuget source. As the previous commit mentioned, if this CLA isn't
specified and the app setting is either not present or not equal to
`true`, the `--prefer-nuget` option is evaluated as it was before.
Will update again when I get `--nuget-source` working with file paths vs
the nuget web API
@forki
Copy link
Member

forki commented Nov 30, 2015

@DavidHayden87 could you please review. thx
I need to make sure it works for anyone.

@allykzam
Copy link
Contributor Author

Should work now as of 14b9b4c; still need to update the code for the bootstrapper to update itself with.

@allykzam
Copy link
Contributor Author

@forki does it make sense to be checking the latestVersion value against String.Empty like this, versus using String.IsNullOrWhiteSpace? Trying to match the surrounding code.

@forki
Copy link
Member

forki commented Nov 30, 2015

I guess nullorwhitespace would be better
On Nov 30, 2015 7:34 PM, "Anthony Perez" [email protected] wrote:

@forki https://github.com/forki does it make sense to be checking the
latestVersion value against String.Empty like this, versus using
String.IsNullOrWhiteSpace? Trying to match the surrounding code.


Reply to this email directly or view it on GitHub
#1268 (comment).

@Haydabase
Copy link
Contributor

I've pulled down the bootstrapper binary from AppVeyor and tried it in our case where we pull from an internal NuGet web server, and it all seems to still work.

Since I've changed this code anyway, updating it to use this method
covers a little more than just comparing against String.Empty.
@allykzam
Copy link
Contributor Author

allykzam commented Dec 1, 2015

@forki Just updated with changes to use String.IsNullOrWhiteSpace in the places I've touched, left all other use of String.Empty as-is for someone else to worry about. 😉

@DavidHayden87 Thanks!

forki added a commit that referenced this pull request Dec 1, 2015
Add options to force Nuget source and use local file paths with bootstrapper
@forki forki merged commit cbb00d2 into fsprojects:master Dec 1, 2015
@allykzam allykzam deleted the issue/1100 branch December 1, 2015 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants