Update ProjectFile.GetTargetProfile to work with conditional nodes #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets the specified property name from the project, evaluating conditional PropertyGroup nodes as best it can and processing MSBuild placeholder values, e.g. `$(Configuration)`
Did this by renaming the old member to GetPropertyWithDefaults, and adding a new member with the old name; new member passes Map.empty<string,string> to the WithDefaults member.
If a <TargetFrameworkProfile> value can be extracted from the project file and it has a value, that value is used to determine the profile here. If that node isn't specified, or its value is empty, GetTargetProfile now tries to get the <TargetFrameworkVersion> node to determine the correct profile from there.
in ProjectWithConditions.fsprojtest
|
this looks good to me. In debugger I see that the files are copiec twice - but the correct files. So it works as expected!
|
forki
added a commit
that referenced
this pull request
Nov 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1221 (cc/ @theggelund and @forki), the contents of the test file I changed in 73e6f8c appear to work as of b905c75.
The output looks correct to me, but I'll need one of you to confirm, as I'm not sure what the output from the paket_bug project is supposed to be. Just testing from an fsx file like so:
profileoutputs asSinglePlatform (DotNetFramework V4_6). If I change theTargetFrameworkProfilenode's condition to check for frameworkv4.6instead, then I getSinglePlatform (DotNetFramework V4_Client). Doesn't make sense since there isn't a client profile for 4.6 (that I know of?), but shows that the condition on the node is being evaluated.