Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates and parses strategy option in lock file #1196

Merged
merged 2 commits into from
Nov 5, 2015
Merged

Generates and parses strategy option in lock file #1196

merged 2 commits into from
Nov 5, 2015

Conversation

mrinaldi
Copy link
Contributor

@mrinaldi mrinaldi commented Nov 5, 2015

This PR generates and parses strategy option in lock file. The lack of it is causing the install process to detect changes when there is none.

Running paket install several times against this paket.dependencies:

source https://www.nuget.org/api/v2/
strategy: min

nuget Paket.Core

would not skip the resolver. Here is the output:

Paket version 2.22.0.0
Resolving packages for group Main:
 - Paket.Core 2.22.0
 - FSharp.Core 3.0.2
 - Newtonsoft.Json 3.5.8
D:\Projects\paket-test\paket.lock is already up-to-date
1 second - ready.

This is the output of this PR:

Paket version 2.22.0.0
Skipping resolver for group Main since it is already up-to-date
D:\Projects\paket-test\paket.lock is already up-to-date
0 seconds - ready.

@forki
Copy link
Member

forki commented Nov 5, 2015

very good.

in the default case (Strategy max) we should not touch the lock file. is this the case?

@mrinaldi
Copy link
Contributor Author

mrinaldi commented Nov 5, 2015

The default case is actually no strategy at all, which internally will be treated as max.
Indeed, for that case, we don't touch the lock file.

If the strategy max is specified though, it'll touch the lock file, and I believe it should, since it's explicit specified.

@forki
Copy link
Member

forki commented Nov 5, 2015

very good!

forki added a commit that referenced this pull request Nov 5, 2015
@forki
Merge pull request #1196 from mrinaldi/lockfile_strategy_option
a6e4d67 
Generates and parses strategy option in lock file
@forki forki merged commit a6e4d67 into fsprojects:master Nov 5, 2015
@mrinaldi mrinaldi deleted the lockfile_strategy_option branch November 5, 2015 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrinaldi @forki