Convert-from-nuget should simplify framework restrictions if possible #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
force-pushed
the
restrictionsimplyfier
branch
3 times, most recently
from
f2e5e72
to
e4d38c1
Compare
| @@ -296,7 296,9 @@ let createDependenciesFileR (rootDirectory : DirectoryInfo) nugetEnv mode = | |||
|
|
|||
| Paket.DependenciesFile(DependenciesFileParser.parseDependenciesFile dependenciesFileName newLines)) | |||
|
|
|||
| if File.Exists dependenciesFileName then read() else create() | |||
| match (if File.Exists dependenciesFileName then read() else create()) with | |||
|
LGTM, wondering if |
|
What would you call it?
|
|
don't mean name itself, but rather the logic - maybe replace ifs with pattern matching where possible - but as I said it's just cosmetics, not crucial |
|
👍 |
|
we now allow to simplify common framework restrictions. see https://github.com/fsprojects/Paket/blob/master/tests/Paket.Tests/Simplifier/BasicScenarioSpecs.fs#L342 |
|
neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #1107
/cc @theimowski could you please take a short look? Thx