Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter by restrictions #1146

Merged
merged 7 commits into from
Oct 17, 2015
Merged

Filter by restrictions #1146

merged 7 commits into from
Oct 17, 2015

Conversation

mrinaldi
Copy link
Contributor

Using a restriction in paket.dependencies, it wouldn't reference the dependencies depending on the restrictions it has.

Examples that were fixed:
>= net35 would not be referenced when paket.dependencies has a >= net40 restriction.
>= net35 < net452 would not be referenced when paket.dependencies has a >= net40 restriction.

Moreover, it would not filter at all dependencies when ranged restrictions were used in paket.dependencies.

Here is a small repro:

framework >= net45
source https://nuget.org/api/v2

nuget Microsoft.Owin.Host.SystemWeb ~> 2.1

Running paket install would generate the following incorrect paket.lock

FRAMEWORK: >= NET45
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Microsoft.Owin.Host.SystemWeb (2.1.0)

On the other hand, the below file would also generate an incorrect paket.lock

framework >= net45 < net46
source https://nuget.org/api/v2

nuget Microsoft.Owin.Host.SystemWeb ~> 2.1

FRAMEWORK: >= NET45 < NET46
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Microsoft.Owin (3.0.1)
      Owin (>= 1.0)
    Microsoft.Owin.Host.SystemWeb (2.1.0)
      Microsoft.Owin (>= 2.1.0) - framework: >= net40
      Microsoft.Web.Infrastructure (>= 1.0.0.0) - framework: net40
      Owin (>= 1.0) - framework: >= net40
    Microsoft.Web.Infrastructure (1.0.0)
    Owin (1.0.0)

This is the correct paket.lock for both cases:

FRAMEWORK: >= NET45
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Microsoft.Owin (3.0.1)
      Owin (>= 1.0)
    Microsoft.Owin.Host.SystemWeb (2.1.0)
      Microsoft.Owin (>= 2.1.0) - framework: >= net40
      Owin (>= 1.0) - framework: >= net40
    Owin (1.0.0)

@mrinaldi
Fixes comparison between AtLeast and AtLeast restrictions because
41478ec 
when a package has a restriction >= net35 and paket.dependencies
has a restriction >= net40, that dependency should be used
@mrinaldi
Fixes comparison between AtLeast and Between restrictions because
73e75bf 
when a package has a restriction >= net35 < net452 and paket.dependencies
has a restriction >= net40, that dependency should be used
@mrinaldi
Fixes comparison between Between and Between restrictions because
2e5026f 
when a package has a restriction >= net30 < net35 and paket.dependencies
has a restriction >= net40 < net451, that dependency should not be used
@mrinaldi
Fixes comparison between Between and Between restrictions because
172e4c4 
when a package has a restriction >= net451 < net46 and paket.dependencies
has a restriction >= net40 < net451, that dependency should not be used
@mrinaldi
Fixes comparison between Between and Exactly restrictions because
4767d02 
when a package has a restriction net451 and paket.dependencies
has a restriction >= net40 < net451, that dependency should not be used
@mrinaldi
Fixes comparison between Between and Exactly restrictions because
7d70417 
when a package has a restriction net35 and paket.dependencies
has a restriction >= net40 < net451, that dependency should not be used
@mrinaldi
Fixes comparison between Between and AtLeast restrictions because
98164fd 
when a package has a restriction >= net451 and paket.dependencies
has a restriction >= net40 < net451, that dependency should not be used
@forki forki merged commit 98164fd into fsprojects:master Oct 17, 2015
@mrinaldi mrinaldi deleted the filter_by_restrictions branch October 18, 2015 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrinaldi @forki