Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsupported https scheme in web proxy #1080

Merged
merged 1 commit into from
Sep 22, 2015
Merged

Fix unsupported https scheme in web proxy #1080

merged 1 commit into from
Sep 22, 2015

Conversation

dedale
Copy link
Contributor

@dedale dedale commented Sep 22, 2015

Finally found a way to push the fix.
Hope it solves #1079

@forki forki merged commit 533886c into fsprojects:master Sep 22, 2015
forki added a commit that referenced this pull request Sep 22, 2015
@forki
Fix unsupported https scheme in web proxy - references #1080
f796058
@forki
Copy link
Member

forki commented Sep 22, 2015

cool thanks.
I fixed the red test cases. could you please review f796058? thx

@dedale
Copy link
Contributor Author

dedale commented Sep 22, 2015

Sorry for the unit tests. You just need to fix the scheme, not the port.
Updated my PR BTW.

@dedale
Copy link
Contributor Author

dedale commented Sep 22, 2015

Mmm If i look at AppVeyor logs, it seems it automatically replaces http://proxy.local:443/ with https://proxy.local/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dedale @forki