fix for parsing output path when condition has no spaces #1058
Conversation
| @@ -639,7 639,7 @@ type ProjectFile = | |||
| let c = input.[index] | |||
| if data.Length = 0 && c = ' ' | |||
| then parseComparison data input (index 1) | |||
| elif data.Length = 2 && c <> ' ' | |||
| elif data.Length = 2 && c <> ' ' && c <> '\'' | |||
There was a problem hiding this comment.
What you wrote here should work fine for #1057.
If I had thought of conditions without spaces when I wrote the parser, I might have written this line as something like so:
let isCompChar c = c = '<' || c = '>' || c = '!' || c = '='
...
elif data.Length = 2 && isCompChar c(helper function so the next elif could be simplified as well)
If you want to do that with this PR, let me know how the tests go; otherwise this looks good to me 👍
There was a problem hiding this comment.
Indeed you're right that is a significantly less naive approach. Pull request amended.
|
Travis build fails, but only because it fails to install mono due to some apt-get 404s:
#itbuildsonmymachine |
|
yes same on FAKE build see fsprojects/FAKE#949 |
fix for parsing output path when condition has no spaces
|
thx |
Fix for issue: #1057
The tests pass, but @amazingant (who wrote the parsing code) may need to double check that to see that it doesn't break any other scenarios.