Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework github strategy to use a more direct method in the common case… #1022

Merged
merged 2 commits into from
Aug 28, 2015
Merged

rework github strategy to use a more direct method in the common case… #1022

merged 2 commits into from
Aug 28, 2015

Conversation

baronfel
Copy link
Contributor

… of just getting the latest version

@baronfel
Copy link
Contributor Author

TODO: pagination on the prerelease-case

@baronfel baronfel changed the title rework github strategy to use a more direct method in the common case… [WIP] rework github strategy to use a more direct method in the common case… Aug 28, 2015
@forki
Copy link
Member

forki commented Aug 28, 2015

I think there should be no pagination on the prerelease case. If there is no prerelease on the first page then there is no active prerelease.

@baronfel
Copy link
Contributor Author

ah, and the prerelease logic is really 'latest including prerelease', so we're really just grabbing the first of the 'all releases' page then? that makes that logic simpler as well.

@forki
Copy link
Member

forki commented Aug 28, 2015

Yes we only want the super latest and greatest (and broken) version.
On Aug 28, 2015 20:11, "Chester Husk III" [email protected] wrote:

ah, and the prerelease logic is really 'latest including prerelease', so
we're really just grabbing the first of the 'all releases' page then? that
makes that logic simpler as well.

—
Reply to this email directly or view it on GitHub
#1022 (comment).

@baronfel
Copy link
Contributor Author

Alright, all better.

@baronfel baronfel changed the title [WIP] rework github strategy to use a more direct method in the common case… rework github strategy to use a more direct method in the common case… Aug 28, 2015
@forki
Copy link
Member

forki commented Aug 28, 2015

thanks!

forki added a commit that referenced this pull request Aug 28, 2015
@forki
Merge pull request #1022 from baronfel/bootstrapper_url
1990385 
rework github strategy to use a more direct method in the common case…
@forki forki merged commit 1990385 into fsprojects:master Aug 28, 2015
@forki
Copy link
Member

forki commented Aug 28, 2015

sorry. I messed up.

The new bootstrapper doesn't work on prerelease case. It should always get the latest version, but github shows the last released version on top (even if that's older than the latest)

@baronfel
Copy link
Contributor Author

sounds like we should always get the latest version via the new mechanism, then, and then use that version to compare against if the user requests a prerelease?

so /releases/latest => 1.99.0
then use 1.99.0 to compare against
/releases =>
1.99.0
2.0.0--alpha1million

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baronfel @forki