Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency when calling install and update #810

Closed
dzendras opened this issue May 1, 2015 · 8 comments
Closed

Inconsistency when calling install and update #810

dzendras opened this issue May 1, 2015 · 8 comments
Labels
bug

Comments

@dzendras
Copy link

dzendras commented May 1, 2015

I found an extremely annoying behaviour of paket (tested against versions 0.42 and 1.3.0)
I have a project which has only one dependency: a nuget package FSharp.Data 2.0.14. The dependency was properly installed, added to the project file, dll downloaded to packages directory. So everything works.

What I expect now is that calling a sequence of commands: update, install, update, intall, update etc. should not change anything at all (as the version is fixed). Unfortunately paket falls into an infinite loop of changes:

  1. paket update - modifies csproj file and paket.lock file.
  2. paket install - discards changes introduced previously by modifying csproj and lock file.
  3. paket update - restores the state of csproj and lock files from the 1st step (by discarding changes made in the 2nd step)

and so on...

I have a sample solution which I'm more than happy to send you for analysis.

paket1

which turns into:

paket2
@dzendras
Copy link
Author

dzendras commented May 1, 2015

Similar behaviour can be observed with another nuget package: Microsoft.AspNet.WebApi

@forki
Copy link
Member

forki commented May 1, 2015

Yes please send me the sample to sforkmann at gmail - I will try to fix it.

@dzendras
Copy link
Author

dzendras commented May 1, 2015

I've just sent it. Good luck! :)

@forki forki added the bug label May 1, 2015
@forki forki closed this as completed in 3b5d91d May 1, 2015
@forki
Copy link
Member

forki commented May 1, 2015

fixed in 1.3.1 - please give it a try

@dzendras
Copy link
Author

dzendras commented May 4, 2015

I did check the repro I sent you using version 1.3.3. There the last paket command ran was install. After I ran update it did modify the lock and csproj file again (why?). However when I ran install afterwards, none of the files were modified (good!). Running update again did nothing (good!).

Unfortunately I was able to reproduce the problem using a different dependency.
I can send you another repro.

@forki
Copy link
Member

forki commented May 4, 2015

Yes the version that update generates is the correct one. So it's expected
that update "wins" and install doesn't change it.

Please send the other repro
On May 4, 2015 15:47, "dzendras" [email protected] wrote:

I did check the repro I sent you using version 1.3.3. There the last paket
command ran was install. After I ran update I did modify the lock and
csproj file again (why?). However when I ran install afterwards, none of
the files were modified (good!). Running update again did nothing (good!).

Unfortunately I was able to reproduce the problem using a different
dependency.
I can send you another repro.

—
Reply to this email directly or view it on GitHub
#810 (comment).

forki added a commit that referenced this issue May 4, 2015
@forki
Windows restrictions were not parsed from lockfile - references #810
6c1624e
@forki
Copy link
Member

forki commented May 4, 2015

I think I fixed your latest repro in 1.3.4

@dzendras
Copy link
Author

dzendras commented May 4, 2015

Confirmed! Thanks! :)

@SavaNDragos SavaNDragos mentioned this issue Oct 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @dzendras