Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paket should pack XML docs into the nupkg #689

Closed
forki opened this issue Mar 10, 2015 · 5 comments
Closed

Paket should pack XML docs into the nupkg #689

forki opened this issue Mar 10, 2015 · 5 comments
Labels
enhancement

Comments

@forki
Copy link
Member

forki commented Mar 10, 2015

/cc @mavnn
Seems we're not packing these files. Also we're missing pdbs

references fsprojects/Chessie#13
@forki
Copy link
Member Author

forki commented Mar 10, 2015

I think I could add this to NupgkWriter.Write. Ok?

@mavnn
Copy link
Contributor

mavnn commented Mar 10, 2015

You probably right that we should pack xml and pdb files as well. Thinking about this, should we be packaging Project.Name.* from the build output directory, or would that include things we should avoid?

@mavnn
Copy link
Contributor

mavnn commented Mar 10, 2015

Or more accurately, Project.Name.* for each dll/exe we determine should be in the package.

@mavnn
Copy link
Contributor

mavnn commented Mar 10, 2015

Doing it in the Write method seems reasonable.

forki added a commit that referenced this issue Mar 10, 2015
@forki
Cleanup - relates to #689
b880378
@forki forki closed this as completed in 8fdc1d5 Mar 10, 2015
@forki
Copy link
Member Author

forki commented Mar 10, 2015

could you please review 8fdc1d5? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @mavnn