Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop touching my paket.dependencies during install #584

Closed
yreynhout opened this issue Feb 8, 2015 · 2 comments
Closed

Stop touching my paket.dependencies during install #584

yreynhout opened this issue Feb 8, 2015 · 2 comments
Assignees
@forki
Labels
bug

Comments

@yreynhout
Copy link

paket install seems to overwrite paket.dependencies, uncommenting any line I've started with //. Very discomforting. Why does this happen? Why even touch that file during an install (I can understand the need during simplify and probably other commands I haven't looked into).

I got the // from digging in the code (who knew I could read F#): https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/DependenciesFile.fs#L171

I haven't ventured into looking why paket is doing this (way past my bed time), so pardon my ignorance.
@forki
Copy link
Member

forki commented Feb 8, 2015

  1. Install scans all references files for new packages and will add these to the dependencies file if needed. So there is a usecase where we save the dependencies file.
  2. Usually the dependencies file will only be saved when it has a modification.
  3. Something went wrong with the comment parsing of the dependencies file in the latest version.

All this together seems to result in the bug you noticed.

@forki forki added the bug label Feb 8, 2015
@forki forki self-assigned this Feb 8, 2015
forki added a commit that referenced this issue Feb 8, 2015
@forki
Add failing test for #584
ed3ba96
@forki forki closed this as completed in 803b2de Feb 8, 2015
@forki
Copy link
Member

forki commented Feb 8, 2015

please test with 0.27.1 and report if you still have such issues. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forki forki

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @yreynhout