Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for non-existing nuget feeds #545

Closed
yreynhout opened this issue Jan 13, 2015 · 10 comments
Closed

Improve error message for non-existing nuget feeds #545

yreynhout opened this issue Jan 13, 2015 · 10 comments
Labels
enhancement

Comments

@yreynhout
Copy link

Given a computer that has a nuget package source that refers to a local folder on that computer and that local folder DOES NOT EXIST,
When running paket convert-from-nuget
Then paket fails with the correct statement that it can not find part of the local folder (aka path).

To be precise, I think it's the implicit (unless --no-install was specified) paket install phase that fails, so the issue might be more general than the conversion from nuget.

However, it is non-obvious to an end-user what that path means nor why paket is even looking at that path. So what I'm asking for is a clearer message upon failure or skipping non-existing package sources silently, whichever matches the paket philosophy best.

Additionaly, once the end-user finds out about this, he can remove the culprit nuget package sources from his list of nuget package sources. But alas, that doesn't help, since at that point paket has already copied those sources into its paket.dependencies. Perhaps the integrity of the paket sources should be verified as well.
@forki
Copy link
Member

forki commented Jan 13, 2015

  1. @theimowski could you try to check if a package feed exists during convert-from-nuget?
  2. I'll try to improve the error message during paket install.

@yreynhout could you please give the corresponding line from the paket.dependencies file (or something similar)?

@forki forki changed the title paket convert-from-nuget crash Improve error message for non-existing nuget feeds Jan 13, 2015
@yreynhout
Copy link
Author

@forki An entry that resembles source c:\path\does\not\exist at the top of that file.

@theimowski
Copy link
Member

I'll take a look tomorrow

forki added a commit that referenced this issue Jan 13, 2015
@forki
Give better error message when package is not found in a local feed -…
5d68614 
… relates to #545
@forki
Copy link
Member

forki commented Jan 13, 2015

In latest version we get the following on install:

image

@theimowski
Copy link
Member

should convert-from-nuget check local feeds only or remote too?

@forki
Copy link
Member

forki commented Jan 14, 2015

probably all.
But the question is what we do if it fails!?

2015-01-14 11:15 GMT 01:00 Tomasz Heimowski [email protected]:

should convert-from-nuget check local feeds only or remote too?

—
Reply to this email directly or view it on GitHub
#545 (comment).

@theimowski
Copy link
Member

nice yellow warning?

@theimowski
Copy link
Member

sometimes nuget v2 feed is also down, so failing because of that seems like an overkill

@forki
Copy link
Member

forki commented Jan 14, 2015

Yes a warning is good.
And then the new error message during install will fail and tell the user
what to do.
On Jan 14, 2015 11:34 AM, "Tomasz Heimowski" [email protected]
wrote:

sometimes nuget v2 feed is also down, so failing because of that seems
like an overkill

—
Reply to this email directly or view it on GitHub
#545 (comment).

@theimowski
Copy link
Member

cool, will do my best to send a PR today

@theimowski theimowski mentioned this issue Jan 14, 2015
Merged
@forki forki closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@forki @yreynhout @theimowski