-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.20.1: paket install takes 40 seconds while 0.18 took 2 seconds #487
Comments
The new version invalidates the cache. So the first install will create a lot more nuget traffic. Is the second install faster? |
No, all |
Ok. That's unfortunate. I'll investigate tomorrow.
|
Do you see this kind of performance issue also on open source project? I think I need something to run the profiler. |
Also: how many projects / references files do you have? |
And I forgot to mention: we redefined the install process. Now it performs a selective update. This means you can edit the dependencies file or references files and "install" will try to make it work with the minimal changes in the lockfile. In order to do so it runs the resolver. That said: the first shot for this selective update is not really optimized and I will try to make it faster. Maybe we could also skip the resolver if we detect no changes. Or things like that. |
I've used it about 30 times today and I think it's really fast. But right now I'm only working towards the public nuget server. |
If it's something to do with multiple nuget sources there's already #331 for that. |
36 seconds is not fast enough. |
This is our
|
Ok. That's sounds a bit like we broke the request caching.
|
14 seconds if I remove all the private packages. Still too slow. |
14 seconds for an install isn't (IMHO) too bad considering it's doing the dependency resolution etc.. Install shouldn't be the standard command to use though - a restore should be much quicker. But if it was 2 seconds before.... |
Sounds like a good benchmark project ;-)
|
There is still A LOT room for improvement... |
Cool! Two of my projects in there ;) |
could you please run the install with 0.20.6? The second install should be a lot faster - I broke the caching in 0.20.0. But I still found some other low hanging fruits as a goal for tomorrow. |
25 seconds first run, 17 seconds subsequent runs. If I remove all private packages, it works really fast (2 seconds). Do I understand right that TeamCity support nuget v1 only and it causes the terrible performance? |
Awesome. There is still one improvement I need to do. Caching with more than one
|
AFAIK - maybe no longer the case? is that every external NuGet feed causes a perf cost as the whole dependency chain must be searched across all feeds. |
Yes that's a separate problem. But here I'm talking about subsequent If you do a full update it's still probing all feeds.
|
please retry with 0.20.10 |
32 seconds first Great job! |
should be even faster now. |
4 seconds. |
No description provided.
The text was updated successfully, but these errors were encountered: