Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Paket.Restore.targets might make bootstrapper not find paket.exe on Windows #3664

Closed
rmunn opened this issue Sep 24, 2019 · 0 comments · Fixed by #3665
Closed

Typo in Paket.Restore.targets might make bootstrapper not find paket.exe on Windows #3664

rmunn opened this issue Sep 24, 2019 · 0 comments · Fixed by #3665

Comments

@rmunn
Copy link
Contributor

rmunn commented Sep 24, 2019

Description

In the Paket.Restore.targets file currently on the master branch, I noticed the following line:

    <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' AND Exists('$(PaketBootStrapperExeDir)') ">$(_PaketBootStrapperExeDir)paket.exe</PaketExePath>

Note the underscore in _PaketBootStrapperExeDir. The rest of the file defines this property as PaketBootStrapperExeDir with no underscore. I believe the underscore is a mistake that might cause the paket.exe file downloaded by the bootstrapper to not be found in the rest of Paket.Restore.targets, since MSBuild will treat $(PropertyNameThatDoesntExist) as the empty string and so the path would be paket.exe rather than .paket\paket.exe (assuming the bootstrapper is located in .paket).

I'll submit a PR to fix this typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant