Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"copy_local: false" has no effect #3645

Closed
yaakov-h opened this issue Sep 3, 2019 · 3 comments
Closed

"copy_local: false" has no effect #3645

yaakov-h opened this issue Sep 3, 2019 · 3 comments

Comments

@yaakov-h
Copy link
Contributor

yaakov-h commented Sep 3, 2019

Description

There seem to be a bit of a history of this (#3154, #3186, #3352).

In my scenario, I'm using the new .NET SDK project format to build a .NET Framework 4.6 assembly.

paket.dependencies:

version 5.216.0 --force-nuget -v

group CsProjCop
	source https://api.nuget.org/v3/index.json
	framework: net46, net472
	storage: none

	nuget Microsoft.Build.Locator
	nuget YamlDotNet

group MSBuild
	source https://api.nuget.org/v3/index.json 
	framework: net46, net472
	storage: none
	lowest_matching: true
	strategy: min
	
	copy_local: false
	copy_content_to_output_dir: never
	
	nuget Microsoft.Build >= 15.0
	nuget Microsoft.Build.Framework >= 15.0
	nuget Microsoft.Build.Utilities.Core >= 15.0

paket.references:

group CsProjCop
	Microsoft.Build.Locator
	YamlDotNet

group MSBuild
	Microsoft.Build copy_local: false
	Microsoft.Build.Framework copy_local: false
	Microsoft.Build.Utilities.Core copy_local: false

Repro steps

  1. Clone https://github.com/yaakov-h/paket-copy-local-repro
  2. Run build.cmd

Expected behavior

  1. The build succeeds
  2. bin\net46 DOES NOT contain:
    • Microsoft.Build.dll
    • Microsoft.Build.Framework.dll
    • Microsoft.Build.Utilities.Core.dll

Actual behavior

  1. The build fails due to an error from Microsoft.Build.Locator's targets file, warning that Microsoft.Build.* is being copied to the output directory.
  2. bin\net46 DOES contain:
    • Microsoft.Build.dll
    • Microsoft.Build.Framework.dll
    • Microsoft.Build.Utilities.Core.dll
@xperiandri
Copy link

xperiandri commented Sep 7, 2019

I have the same issue with netstandard2.0 project but wise verse

@yaakov-h
Copy link
Contributor Author

yaakov-h commented Sep 19, 2019

git-bisect puts the blame at 88620a9 (#3417).

Any idea what's happened here, @matthid?

@yaakov-h
Copy link
Contributor Author

yaakov-h commented Sep 19, 2019

This seems wrong to me:

<ExcludeAssets Condition=" '%(PaketReferencesFileLinesInfo.Splits)' != '6' And %(PaketReferencesFileLinesInfo.AllPrivateAssets) == 'exclude'">runtime</ExcludeAssets>~

Shouldn't %(PaketReferencesFileLinesInfo.AllPrivateAssets) == 'exclude' be %(PaketReferencesFileLinesInfo.AllPrivateAssets) == 'false'?

Edit: Never mind, that wasn't the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants