Paket update problem in sdk style project #3618

Sylwekqaz · 2019-07-22T08:32:33Z

Description

After package update (in paket.dependencies and paket.lock) and restore packages, old packages are copied to bin dir. Probably they are cached in obj\project.assets.json.

Repro steps

Create new sdk style project (e.g. net core project) and add packet

Example main function

static void Main(string[] args)
{
    var version = FileVersionInfo.GetVersionInfo("Newtonsoft.Json.dll");
    Console.WriteLine(version.FileVersion);
    Console.WriteLine(JsonConvert.SerializeObject(new
        {
            version.ProductName,
            version.FileVersion,
            version.ProductVersion,
        },
        Formatting.Indented));
    Console.ReadKey();
}

Reference package (e.g. Newtonsoft.Json = 12.0.1)

Compile & run program

paket install
dotnet restore
dotnet run
# Output
# 12.0.1.22727
# {
#   "ProductName": "Json.NET",
#   "FileVersion": "12.0.1.22727",
#   "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"
# }

To bin folder was copied Newtonsoft.Json.dll in version 12.0.1.22727, with is correct.

Update package in paket.dependencies (e.g. Newtonsoft.Json = 12.0.2)

Compile & run program

paket install
dotnet restore
dotnet run
# Output
# 12.0.1.22727
# {
#   "ProductName": "Json.NET",
#   "FileVersion": "12.0.1.22727",
#   "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"
# }

To bin folder was copied Newtonsoft.Json.dll in version 12.0.1.22727, with is not correct.

Expected behavior

Packages should be restored with correct version

dotnet run
# 12.0.2.23222
# {
#   "ProductName": "Json.NET",
#   "FileVersion": "12.0.2.23222",
#   "ProductVersion": "12.0.2 4ab34b0461fb595805d092a46a58f35f66c84d6a"
# }

Actual behavior

Packages are restored with old version version

dotnet run
# Output
# 12.0.1.22727
# {
#   "ProductName": "Json.NET",
#   "FileVersion": "12.0.1.22727",
#   "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"
# }

Packages probably are cached in obj\project.assets.json and restored in old version to bin folder. Rebuild/clean project dosent help.

Known workarounds

Delete obj folders in projects.

The text was updated successfully, but these errors were encountered:

forki · 2019-07-22T08:44:30Z

Cc @matthid is that related to "fast restore"? Sylwester <[email protected]> schrieb am Mo., 22. Juli 2019, 10:32:

…

Description After package update (in paket.dependencies and paket.lock) and restore packages, old packages are copied to bin dir. Probably they are cached in obj\project.assets.json. Repro steps 1. Create new sdk style project (e.g. net core project) and add packet Example main function static void Main(string[] args) { var version = FileVersionInfo.GetVersionInfo("Newtonsoft.Json.dll"); Console.WriteLine(version.FileVersion); Console.WriteLine(JsonConvert.SerializeObject(new { version.ProductName, version.FileVersion, version.ProductVersion, }, Formatting.Indented)); Console.ReadKey(); } 2. Reference package (e.g. Newtonsoft.Json = 12.0.1) 3. Compile & run program paket install dotnet restore dotnet run# Output# 12.0.1.22727# {# "ProductName": "Json.NET",# "FileVersion": "12.0.1.22727",# "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"# } To bin folder was copied Newtonsoft.Json.dll in version 12.0.1.22727, with is correct. 4. Update package in paket.dependencies (e.g. Newtonsoft.Json = 12.0.2) 5. Compile & run program paket install dotnet restore dotnet run# Output# 12.0.1.22727# {# "ProductName": "Json.NET",# "FileVersion": "12.0.1.22727",# "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"# } To bin folder was copied Newtonsoft.Json.dll in version 12.0.1.22727, with is not correct. Expected behavior Packages should be restored with correct version dotnet run# 12.0.2.23222# {# "ProductName": "Json.NET",# "FileVersion": "12.0.2.23222",# "ProductVersion": "12.0.2 4ab34b0461fb595805d092a46a58f35f66c84d6a"# } Actual behavior Packages are restored with old version version dotnet run# Output# 12.0.1.22727# {# "ProductName": "Json.NET",# "FileVersion": "12.0.1.22727",# "ProductVersion": "12.0.1 509643a8952ce731e0207710c429ad6e67dc43db"# } Packages probably are cached in obj\project.assets.json and restored in old version to bin folder. Rebuild/clean project dosent help. Known workarounds Delete obj folders in projects. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3618?email_source=notifications&email_token=AAAOANEZWCHPDOT7IVUD2K3QAVWCFA5CNFSM4IFWERBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HASKTTA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAOANFUDNATYKAGRCIJBULQAVWCFANCNFSM4IFWERBA> .

matthid · 2019-07-22T09:17:30Z

maybe, what 'should' happen is that lockfile gets updated which invalidates the various cache files and the msbuild integration should pick it up if required.
In this particular scenario paket install should update all the cache files and dotnet restore should be fast

danyx23 · 2019-09-04T11:21:45Z

I think I ran into this problem as well in a SAFE stack application. After upgrading paket.dependencies to bump a library from version 3.1 to 3.2 and running paket install (or doing the same via paket update) the paket.lock file contains the correct new entry but the /src/Client/obj/Client.fsproj.reference file still lists the old library version so Fable restores this old library version and then I wondered why the behaviour did not change.

Deleting the obj folder forces a refresh of this file and then everything works as expected.

forki · 2019-09-04T13:06:09Z

@danyx23 any chance for repro?

forki · 2019-09-04T13:14:57Z

ok I think I found the issue. we are nuking he assets file butkeep all Paket files intact. this is a bug

forki · 2019-09-04T13:23:45Z

b13d806 <- waiting for CI

danyx23 · 2019-09-04T13:27:59Z

@forki I have this repo that I was using as the example (https://github.com/danyx23/safe-stack-sweet-alert-debug) that is currently at Elmish.SweetAlert 3.1 and if you build and then upgrade to 3.2 it exhibits the problem. I'll try the new version as soon as it is published - thanks for the fast fix!

forki · 2019-09-04T16:03:41Z

published. please give it a try

danyx23 · 2019-09-04T16:39:27Z

@forki thanks! The bug that I described is fixed in the new version but the delete is too agressive - it deletes the paket.references files in the source directories which then breaks the builds!

baronfel · 2019-09-04T17:04:40Z

Agree with @danyx23, just saw this happen to me as well. luckily git checkout is a thing :)

forki · 2019-09-04T17:26:19Z

Revert is released Chet Husk <[email protected]> schrieb am Mi., 4. Sep. 2019, 19:04:

…

Agree with @danyx23 <https://github.com/danyx23>, just saw this happen to me as well. luckily git checkout is a thing :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3618?email_source=notifications&email_token=AAAOANHTSIB467CR72WSKWTQH7TCRA5CNFSM4IFWERBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54IYRA#issuecomment-527993924>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAOANGUGYX7ITFD3UNXTD3QH7TCRANCNFSM4IFWERBA> .

forki · 2019-09-04T17:50:24Z

5.218.0-alpha001 should be available in couple of minutes. Can you please try it? Am Mi., 4. Sept. 2019 um 19:26 Uhr schrieb Steffen Forkmann < [email protected]>:

…

Revert is released Chet Husk ***@***.***> schrieb am Mi., 4. Sep. 2019, 19:04: > Agree with @danyx23 <https://github.com/danyx23>, just saw this happen > to me as well. luckily git checkout is a thing :) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3618?email_source=notifications&email_token=AAAOANHTSIB467CR72WSKWTQH7TCRA5CNFSM4IFWERBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54IYRA#issuecomment-527993924>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAAOANGUGYX7ITFD3UNXTD3QH7TCRANCNFSM4IFWERBA> > . >

forki · 2019-09-04T18:04:00Z

new alpha should be available

danyx23 · 2019-09-04T18:36:34Z

Works like a charm. Thanks a lot for your great work @forki!

forki · 2019-09-04T18:48:00Z

cool so I'm releasing it properly. Thanks for your help with testing

danyx23 mentioned this issue Sep 4, 2019

"undefined is not a constructor" error when used in a SAFE stack app Zaid-Ajaj/Elmish.SweetAlert#1

Closed

forki closed this as completed Sep 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Paket update problem in sdk style project #3618

Paket update problem in sdk style project #3618

Sylwekqaz commented Jul 22, 2019

forki commented Jul 22, 2019 via email

matthid commented Jul 22, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019

forki commented Sep 4, 2019

forki commented Sep 4, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019 •

edited

Loading

danyx23 commented Sep 4, 2019

baronfel commented Sep 4, 2019

forki commented Sep 4, 2019 via email

forki commented Sep 4, 2019 via email

forki commented Sep 4, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019

Paket update problem in sdk style project #3618

Paket update problem in sdk style project #3618

Comments

Sylwekqaz commented Jul 22, 2019

Description

Repro steps

Expected behavior

Actual behavior

Known workarounds

forki commented Jul 22, 2019 via email

matthid commented Jul 22, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019

forki commented Sep 4, 2019

forki commented Sep 4, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019 • edited Loading

danyx23 commented Sep 4, 2019

baronfel commented Sep 4, 2019

forki commented Sep 4, 2019 via email

forki commented Sep 4, 2019 via email

forki commented Sep 4, 2019

danyx23 commented Sep 4, 2019

forki commented Sep 4, 2019

forki commented Sep 4, 2019 •

edited

Loading