Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-to-nuget should not delete nuget.exe #320

Closed
haf opened this issue Nov 1, 2014 · 5 comments
Closed

convert-to-nuget should not delete nuget.exe #320

haf opened this issue Nov 1, 2014 · 5 comments

Comments

@haf
Copy link
Member

haf commented Nov 1, 2014

Unless it can also push to nuget, because that file might be in the source tree because I need to push the package.

@forki
Copy link
Member

forki commented Nov 1, 2014

I removed that manually for suave and added Nuget.commandline as a package
in the dependencies file.

So the path changes. I did that in the rake file.
On Nov 1, 2014 6:06 PM, "Henrik Feldt" [email protected] wrote:

Unless it can also push to nuget, because that file might be in the source
tree because I need to push the package.


Reply to this email directly or view it on GitHub
#320.

@haf
Copy link
Member Author

haf commented Nov 1, 2014

Ah, I see, thank you. Perhaps consider this issue to be a 'warning' on deletion then?

On 01 Nov 2014, at 18:19, Steffen Forkmann [email protected] wrote:

I removed that manually for suave and added Nuget.commandline as a package
in the dependencies file.

So the path changes. I did that in the rake file.
On Nov 1, 2014 6:06 PM, "Henrik Feldt" [email protected] wrote:

Unless it can also push to nuget, because that file might be in the source
tree because I need to push the package.


Reply to this email directly or view it on GitHub
#320.


Reply to this email directly or view it on GitHub.

@forki
Copy link
Member

forki commented Nov 1, 2014

Yes we have to make this more obvious. I think tracing a warning is a good
idea.
On Nov 1, 2014 6:20 PM, "Henrik Feldt" [email protected] wrote:

Ah, I see, thank you. Perhaps consider this issue to be a 'warning' on
deletion then?

On 01 Nov 2014, at 18:19, Steffen Forkmann [email protected]
wrote:

I removed that manually for suave and added Nuget.commandline as a
package
in the dependencies file.

So the path changes. I did that in the rake file.
On Nov 1, 2014 6:06 PM, "Henrik Feldt" [email protected]
wrote:

Unless it can also push to nuget, because that file might be in the
source
tree because I need to push the package.


Reply to this email directly or view it on GitHub
#320.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#320 (comment).

@theimowski
Copy link
Member

IIRC, convert-from-nuget will add the Nuget.CommandLine package to dependencies if it removed Nuget.exe, but yes, a warning message to change the paths should be output

@forki
Copy link
Member

forki commented Nov 1, 2014

Yes, but suave had it in tools folder. So I did it manually.
On Nov 1, 2014 6:29 PM, "Tomasz Heimowski" [email protected] wrote:

IIRC, convert-from-nuget will add the Nuget.CommandLine package to
dependencies if it removed Nuget.exe, but yes, a warning message to change
the paths should be output


Reply to this email directly or view it on GitHub
#320 (comment).

@forki forki closed this as completed in fb4b991 Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants