Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry HTTP downloads #3088

Closed
agross opened this issue Feb 27, 2018 · 3 comments
Closed

Retry HTTP downloads #3088

agross opened this issue Feb 27, 2018 · 3 comments

Comments

@agross
Copy link
Contributor

agross commented Feb 27, 2018

Description

When a http dependency fails to download, please retry the request. I see a lot of transient errors with sourceforge.

Repro steps

  1. Add http https://downloads.sourceforge.net/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip and try to restore.

Expected behavior

Retry like we do with NuGets for x times, then fail.

Actual behavior

Paket version 5.145.6
Downloading downloads.sourceforge.net/:/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip optipng-0.7.7-win32.zip to C:\BuildAgent\work\e3efd18142ae7728\paket-files\downloads.sourceforge.net\optipng-0.7.7-win32.zip
Performance:
 - Average Download Time: 22 seconds
 - Number of downloads: 1
 - Runtime: 22 seconds
Paket failed with
-> Could not download from 'https://downloads.sourceforge.net/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip'
-> HttpRequestException: An error occurred while sending the request.
-> WebException: Unable to connect to the remote server
-> SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond 5.10.152.194:443

Known workarounds

Restart paket restore.
@forki forki closed this as completed in 06aea52 Feb 28, 2018
forki added a commit that referenced this issue Feb 28, 2018
@forki
Retry HTTP downloads - fixes #3088
6895840
@agross
Copy link
Contributor Author

agross commented Feb 28, 2018

Thank you very much!

@forki
Copy link
Member

forki commented Feb 28, 2018

image

already helping me in another scenario...

@agross
Copy link
Contributor Author

agross commented Feb 28, 2018

I'm glad you benefit as well :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agross @forki