Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate framework assembly references #297

Closed
ctaggart opened this issue Oct 24, 2014 · 7 comments
Closed

duplicate framework assembly references #297

ctaggart opened this issue Oct 24, 2014 · 7 comments
Labels

Comments

@ctaggart
Copy link
Contributor

I've had to lock our use of paket to 0.8.5. The breaking issue is that FSharp.Data.SqlClient isn't showing up as a reference in one of our projects after a paket update with 0.9.7. I haven't been able to isolate the problem in a test solution yet.

However, I created a project and added a handful of commits to it, trying to reproduce the issues I'm seeing. This is the first one that may be related. I'm seeing more duplicate references with 0.9.7:

https://github.com/ctaggart/Paket09x/commits

image

0.8.5 just has Microsoft.SqlServer.Types listed twice:

image

@forki
Copy link
Member

forki commented Oct 24, 2014

Thanks I will look into this in Monday
On Oct 24, 2014 8:01 PM, "Cameron Taggart" [email protected] wrote:

I've had to lock our use of paket to 0.8.5. The breaking issue is that
FSharp.Data.SqlClient isn't showing up as a reference in one of our
projects after a paket update with 0.9.7. I haven't been able to isolate
the problem in a test solution yet.

However, I created a project and added a handful of commits to it, trying
to reproduce the issues I'm seeing. This is the first one that may be
related. I'm seeing more duplicate references with 0.9.7:

https://github.com/ctaggart/Paket09x/commits

[image: image]
https://cloud.githubusercontent.com/assets/80104/4773896/963b7156-5ba7-11e4-8179-e91e78e5a317.png

0.8.5 just has Microsoft.SqlServer.Types listed twice:

[image: image]
https://cloud.githubusercontent.com/assets/80104/4773905/a8f55a82-5ba7-11e4-9f58-be63030ca544.png


Reply to this email directly or view it on GitHub
#297.

@ctaggart
Copy link
Contributor Author

It looks like it may be an issue with the nuspec for the FSharp.Data.SqlClient project. I submitted a pull request. fsprojects/FSharp.Data.SqlClient#75 When I get the new version, I'll try again.

@ctaggart
Copy link
Contributor Author

The SqlClient bug solved the duplicate Microsoft.SqlServer.Types, but not any of the frameworksAssemblies duplicate references. Looks like a problem with #146.

I simplified the example solution to have these two dependencies.

source https://nuget.org/api/v2

nuget Microsoft.AspNet.WebApi.Client
nuget Microsoft.Owin.Testing

Their nuspec files have:

    <frameworkAssemblies>
      <frameworkAssembly assemblyName="System.Net.Http" targetFramework=".NETFramework4.5" />
    </frameworkAssemblies>

Which leads to this in 0.8.5:
image

and this is 0.9.7:
image

@ctaggart ctaggart changed the title duplicate references duplicate framework assembly references Oct 24, 2014
@forki
Copy link
Member

forki commented Oct 27, 2014

I think we need to check if it already exists

@forki forki closed this as completed in 035edbb Oct 27, 2014
@forki forki reopened this Oct 28, 2014
@forki
Copy link
Member

forki commented Oct 28, 2014

First try was wrong

@forki
Copy link
Member

forki commented Oct 28, 2014

could you please test 0.11.0-alpha001?

@forki forki added the bug label Oct 28, 2014
@forki forki closed this as completed Oct 28, 2014
@ctaggart
Copy link
Contributor Author

Tested this an it appears to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants