Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle .Net 4.5.2 projects #260

Closed
Ravadre opened this issue Oct 14, 2014 · 4 comments
Closed

Handle .Net 4.5.2 projects #260

Ravadre opened this issue Oct 14, 2014 · 4 comments

Comments

@Ravadre
Copy link

Ravadre commented Oct 14, 2014

When I have a project which targets .net 4.5.2 and downloaded package has lib version of 4.5, Paket does not add references to that project. packet.references file is created in project directory correctly. I tried converting from nuget and then paket install --force as well as paket restore.

After inspecting changes to *.csproj I can see that Paket recognized and added guards for 4.5 and 4.5.1 versions correctly (4.5.1 is referencing path to 4.5 inside nuget package), but not for 4.5.2. Is creating 3rd When block for 4.5.2 an ok solution?
@agross
Copy link
Contributor

agross commented Oct 14, 2014

Is there a lib/net452 folder in the nuget?

@Ravadre
Copy link
Author

Ravadre commented Oct 14, 2014

@agross No, but there's no 451 neither and 4.5.1 guards are added. I'm just watching paket source and I can see that 4.5.2 is just not yet handled I guess. (https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/FrameworkHandling.fs#L42-L43).

I wonder what is proper behavior here? Ignore if no net452 is present or link to net45? I think it should be consistent with 4.5.1 behavior?

@agross
Copy link
Contributor

agross commented Oct 14, 2014

Yeah, you're probably the first one to target 4.5.2, so we never thought about supporting it in the first place.

I was just asking because it could have been that there's a special lib for 4.5.2. Documentation on allowed framework versions is a bit sparse. But I guess we should handle lib/net452 just like we did with lib/net451. I.e. lib/net4xxx should be installed for 4.5.2 as well.

@forki
Copy link
Member

forki commented Oct 14, 2014

It should inherit from 4.5.1. - it's an easy fix. If no one finds it
tonight I will do it tomorrow.
On Oct 14, 2014 11:14 PM, "Marcin Deptuła" [email protected] wrote:

@agross https://github.com/agross No, but there's no 451 neither and
4.5.1 guards are added. I'm just watching paket source and I can see that
4.5.2 is just not yet handled I guess. (
https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/FrameworkHandling.fs#L42-L43
).

I wonder what is proper behavior here? Ignore if no net452 is present or
link to net45? I think it should be consistent with 4.5.1 behavior?

—
Reply to this email directly or view it on GitHub
#260 (comment).

@forki forki closed this as completed in 89287f9 Oct 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agross @forki @Ravadre