Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate-load-scripts case sensitivity #2547

Closed
TheAngryByrd opened this issue Jul 20, 2017 · 7 comments
Closed

generate-load-scripts case sensitivity #2547

TheAngryByrd opened this issue Jul 20, 2017 · 7 comments
Labels
bug needs-test-case

Comments

@TheAngryByrd
Copy link
Contributor

TheAngryByrd commented Jul 20, 2017 •
edited
Loading

Description

generate-load-scripts has problems with casing. This doesn't really affect Windows or macOS since they don't care, but this really affects anything linux related.

paket exits with the error

Paket failed with
-> DirectoryNotFoundException: Could not find a part of the path "/app/packages/tests/Foq/lib/net45/Foq.dll".

Repro steps

https://github.com/TheAngryByrd/generate-load-scripts-casing-repro

Expected behavior

paket generates load scripts with correct casing in filepaths

Actual behavior

paket does not generate load scripts with correct casing in filepaths

Known workarounds

Use an insane OS like Windows or macOS :trollface:
@matthid
Copy link
Member

matthid commented Jul 20, 2017

Might be related to the fix of #2533

@matthid matthid added the bug label Jul 20, 2017
@forki
Copy link
Member

forki commented Jul 21, 2017

@TheAngryByrd are you sure it's still an issue?
Is so can you please run it with -v?

@forki
Copy link
Member

forki commented Jul 21, 2017

image

@matthid
Copy link
Member

matthid commented Jul 21, 2017

repro works after converting build.sh to unix line feeds on windows...
I usually use git bash and dos2unix build.sh for that.

Problem is that windows git is checking out with windows crlf and if that gets added to the container it won't work.

@forki
Copy link
Member

forki commented Jul 21, 2017

nice repro!

@forki forki closed this as completed in 3d84116 Jul 21, 2017
@TheAngryByrd
Copy link
Contributor Author

🎸

@agross
Copy link
Contributor

agross commented Jul 28, 2017

Problem is that windows git is checking out with windows crlf

Can be solved with .gitattributes:
https://github.com/fsprojects/Paket/blob/master/completion/.gitattributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-test-case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@agross @forki @TheAngryByrd @matthid