Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support frameworkAssemblies from nuspec #241

Closed
agross opened this issue Oct 11, 2014 · 8 comments
Closed

Support frameworkAssemblies from nuspec #241

agross opened this issue Oct 11, 2014 · 8 comments

Comments

@agross
Copy link
Contributor

agross commented Oct 11, 2014

E.g. from Microsoft.Net.Http:

    <frameworkAssemblies>
      <frameworkAssembly assemblyName="System.Net.Http" targetFramework=".NETFramework4.5" />
      <frameworkAssembly assemblyName="System.Net.Http.WebRequest" targetFramework=".NETFramework4.5" />
      <frameworkAssembly assemblyName="System.Net.Http" targetFramework="MonoTouch0.0" />
      <frameworkAssembly assemblyName="System.Net.Http" targetFramework="MonoAndroid0.0" />
    </frameworkAssemblies>
@forki
Copy link
Member

forki commented Oct 11, 2014

What do we need to emit in this sample?
On Oct 11, 2014 4:55 PM, "Alexander Groß" [email protected] wrote:

E.g. from Microsoft.Net.Http:

<frameworkAssemblies>
  <frameworkAssembly assemblyName="System.Net.Http" targetFramework=".NETFramework4.5" />
  <frameworkAssembly assemblyName="System.Net.Http.WebRequest" targetFramework=".NETFramework4.5" />
  <frameworkAssembly assemblyName="System.Net.Http" targetFramework="MonoTouch0.0" />
  <frameworkAssembly assemblyName="System.Net.Http" targetFramework="MonoAndroid0.0" />
</frameworkAssemblies>


Reply to this email directly or view it on GitHub
#241.

@forki
Copy link
Member

forki commented Oct 12, 2014

<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Net.Http" />
<Reference Include="System.Net.Http.Extensions">
  <HintPath>..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Extensions.dll</HintPath>
  <Private>True</Private>
</Reference>
<Reference Include="System.Net.Http.Primitives">
  <HintPath>..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Primitives.dll</HintPath>
  <Private>True</Private>
</Reference>
<Reference Include="System.Net.Http.WebRequest" />
<Reference Include="System.Numerics" />

@agross
Copy link
Contributor Author

agross commented Oct 12, 2014

As these need to be referenced depending on the target framework, we need to figure out which version strings are valid.

I'm so glad that they chose to invent another system to specify the framework version! #not

Alex

Alexander Groß
Tiny phone, tiny mail

On Sun, Oct 12, 2014 at 10:03 AM, Steffen Forkmann
[email protected] wrote:

<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Net.Http" />
<Reference Include="System.Net.Http.Extensions">
  <HintPath>..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Extensions.dll</HintPath>
  <Private>True</Private>
</Reference>
<Reference Include="System.Net.Http.Primitives">
  <HintPath>..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Primitives.dll</HintPath>
  <Private>True</Private>
</Reference>
<Reference Include="System.Net.Http.WebRequest" />
<Reference Include="System.Numerics" />

Reply to this email directly or view it on GitHub:
#241 (comment)

@forki
Copy link
Member

forki commented Oct 12, 2014

yep that's fun.

@forki
Copy link
Member

forki commented Oct 12, 2014

if anybody finds the mapping in the nuget sources...

@agross
Copy link
Contributor Author

agross commented Oct 12, 2014

The docs say the same strings as in lib are supported.

@forki
Copy link
Member

forki commented Oct 12, 2014

Ok. But why don't they use these? ;-)
On Oct 12, 2014 10:27 AM, "Alexander Groß" [email protected] wrote:

The docs say
http://docs.nuget.org/docs/reference/nuspec-reference#Specifying_Framework_Assembly_References_(GAC)
the same strings as in lib are supported.


Reply to this email directly or view it on GitHub
#241 (comment).

@agross
Copy link
Contributor Author

agross commented Oct 12, 2014

Seems like .NETFramework is an alias for net (take a look at _knownIdentifiers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants