Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyChange detection is wrong for runtime graph #2334

Closed
forki opened this issue May 13, 2017 · 2 comments
Closed

DependencyChange detection is wrong for runtime graph #2334

forki opened this issue May 13, 2017 · 2 comments

Comments

@forki
Copy link
Member

forki commented May 13, 2017

run paket restore and dependency change detection will go crazy on it. Basically every package will be reported as "not in deps file". I think the issue is that GetTransitiveDependencies is calculating wrong result.

Basically that function looks into all nuspecs and computes union of all deps. But since runtime dependency resolution we retrieve deps from within the package. So this is no longer correct.

@matthid any chance you could fix that function?
@matthid
Copy link
Member

matthid commented May 13, 2017

Oh crap. Yes I will fix this, but probably in a week (or maybe tomorrow).

Basically I think it just needs to ignore deps in the lockfile which are marked with isRuntimeDependency: true

@forki forki closed this as completed in cd501c8 May 13, 2017
@matthid
Copy link
Member

matthid commented May 13, 2017

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @matthid