Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include-referenced-projects lead to strange changes in nuspec #1848

Closed
lexarchik opened this issue Aug 4, 2016 · 2 comments · Fixed by #2753
Closed

include-referenced-projects lead to strange changes in nuspec #1848

lexarchik opened this issue Aug 4, 2016 · 2 comments · Fixed by #2753

Comments

@lexarchik
Copy link
Contributor

I have two projects ProjA, ProjB.
Both have paket.template files.
ProjA have reference to ProjB (in .csproj file)

I execute paket pack output test in solution folder
In result package ProjA have a dependence with min version specified to package ProjB.

But if i execute paket pack output test include-referenced-projects
result package ProjA have a dependence without specified version to package ProjB
(pin-project-references do not change situation in this case)

Expected behavior: ProjA have a dependence with min version to ProjB (or with fixed version if pin-project-references was specified)

Sample solution in attached archive
PackIncludeRefProj.zip
@forki
Copy link
Member

forki commented Aug 5, 2016

/cc @jam40jeff @tsibelman

@jam40jeff
Copy link
Contributor

jam40jeff commented Aug 5, 2016 •
edited
Loading

@forki I have verified that this behavior existed before the introduction of pin-project-references. I am not too familiar with include-referenced-projects as I have not used it, but it seems to have always worked this way (which doesn't seem correct). However, I am not sure I see much benefit to this command line option, as including a paket.template file for each project in the solution is a one-time cost which also provides other benefits.

lexarchik pushed a commit to lexarchik/Paket that referenced this issue Sep 10, 2017
fix for fsprojects#1848
767417c
@lexarchik lexarchik mentioned this issue Sep 10, 2017
Merged
lexarchik pushed a commit to lexarchik/Paket that referenced this issue Sep 11, 2017
fix for fsprojects#1848
9e3f9c7
This was referenced Sep 14, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for include-referenced-projects flag lexarchik/Paket
3 participants
@forki @jam40jeff @lexarchik