-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent space handling during packaging and unpackaging of nuget packages. #1837
Comments
I'd need to have a repro sample. |
Includes paket.template and the fallback nuspec. |
ok extracted the zip. what do I have to do exactly to see the error? |
Use the attached template and create nuget package using paket. Then use paket to extract the same package. |
Looking at the content of the generated nupkg actually reveals one side of the problem. Spaces in file and folder names have all been replaced. The idea is to reverse this on unpacking and it is here it can go wrong since the space-replacing is inconsistent. |
Description
We have a nuget package where there are lots of spaces in file and folder names. We experience two different levels of inconsistency related to this repository:
Repro steps
Due to the inconsitency (and apparent arbitrariness) it might take some effort to reproduce.
You need
a. A project with files and folders with spaces in the names. Use paket to generate a nuget package of this project.
b. A project that depends on this package (in its paket.dependencies).
Build project b).
Expected behavior
On building project b) the package from a) is fetched and unpacked.
Actual behavior
On building project b) the package from a) is fetched and unpacked. During unpacking there will be an exception indicating "Directory not found" or similar.
Known workarounds
Use nuget pack instead.
With nuget there is no space conversion at all, spaces go straight through and everything works.
Related information
The exception gives a fair hint into failing code, which has enabled med to set breakpoints and watch variables. Is is all in method NugetV2.cleanup where I can follow the inconsistent and somewhat strange input and how Uri.UnescapeDatastring does not produce the expected result. The eventual exception comes from File.Move in the same method, but looking at variables during debugging might provide enough clues even if you are not able to make it actually crash.
The text was updated successfully, but these errors were encountered: