Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack no longer generates dependencies based on referenced projects in a solution #1429

Closed
kolektiv opened this issue Jan 24, 2016 · 4 comments
Labels

Comments

@kolektiv
Copy link

Paket pack given a template would generate dependencies for the other referenced projects in the solution which also had template files (and thus would also be packages). Given a project One and a project Two in a solution, if both had a paket.template, and Two referenced One, when generating the package, Paket would include One as a dependency of Two in the generated package.

This stopped working in the 2.46.2 -> 2.47.0 range (see 3239957...3334d3d for a relevant comparison). It seems like the work to bring in referenced projects dependencies (which I'm not sure I understand the point of) may have wiped out this functionality. It is possible that this functionality would still work if include-referenced-projects was passed to Paket, but this configuration option does not yet appear in the Paket helper in Fake, so it's difficult to test this possibility.

Either way, I would consider it a regression, either removing the functionality without intent, or moving it behind a switch which previously did not exist and thus was a default true. I published a horribly broken set of packages today which had half of their dependencies missing before noticing this - hopefully I'll be the only one 😄 - thankfully they were prerelease!

If any more info is needed to repro, don't hesitate to ask...

@inosik
Copy link
Contributor

inosik commented Jan 25, 2016

Same here. include-referenced-projects seems to help, but I think that the behavior shouldn't have changed in first place.

@inosik
Copy link
Contributor

inosik commented Jan 25, 2016

/cc @pms1969

@forki forki added the bug label Jan 25, 2016
@forki
Copy link
Member

forki commented Jan 25, 2016

confirmed. this is a regression and shouldn't have happened.
I though we only add behaviour under the switch. The old automatic dependency recognition shouldn't change.

I'm working on integration tests and will try to come up with a fix.

forki added a commit that referenced this issue Jan 25, 2016
forki added a commit that referenced this issue Jan 25, 2016
forki added a commit that referenced this issue Jan 25, 2016
forki added a commit that referenced this issue Jan 25, 2016
forki added a commit that referenced this issue Jan 25, 2016
forki added a commit that referenced this issue Jan 25, 2016
@kolektiv
Copy link
Author

Update: Confirmed fixed for my original case in 2.47.2.0 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants