-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackOverflowException resolving NuGet package without version constraint from large paket.dependencies #1392
Comments
can you please try to find the last working version? |
OK, the issue appears between 2.40.14 (latest working) and 2.40.15 (throws SO).
|
that's the only change. weird |
but I assume the real issue is that our resolver algorithm is still recursive. Need to implement BFS qith a queue... |
@viktor-svub in the latest version I inline the tryToImprove function. This will "free" halve of the stack in your sample and should help to process significantly larger graphs. Does this work for you? @mrinaldi do you see a chance that we can remove the recursive step function and turn it into something that manages a queue or a stack internally? |
IIRC yes. |
I noticed the same problem (SO during paket update --no-install). The last working version is 2.40.14, 2.44.5 still fails |
can any of you reproduce with a dependencies file that can be made public? |
We were not able to reproduce it using public packages only yet. it's a mix of public libs and internal libs |
maybe exclude the internal stuff and add public packages until it breaks again? |
This fixed in 2.50.3 |
StackOverflowException resolving "our.proprietary.component"
(this.GetCompareString().CompareTo(that.GetCompareString()))
The text was updated successfully, but these errors were encountered: