Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket does not put .props and .targets import project on correct location in project files #1219

Closed
theggelund opened this issue Nov 13, 2015 · 8 comments
Labels

Comments

@theggelund
Copy link

When Paket installs a nuget package with {packageid}.props/{packageid}.targets in build folder, it should

  1. Put '' as the first child element in Project element
  2. Put '' as the last child element in Project element

Paket puts both imports in the middle of csproj file and by doing so, breaks compatiblity with nuget feature "Import MSBuild targets and props files into project"

@forki
Copy link
Member

forki commented Nov 13, 2015

Do you have a csproj file and a dependencies file (or just nuget package
name) for me to create a integration test?
On Nov 13, 2015 1:29 PM, "Thomas Heggelund" [email protected]
wrote:

When Paket installs a nuget package with
{packageid}.props/{packageid}.targets in build folder, it should

  1. Put '' as the first
    child element in Project element
  2. Put '' as the
    last child element in Project element

Paket puts both imports in the middle of csproj file and by doing so,
breaks compatiblity with nuget feature "Import MSBuild targets and props
files into project"


Reply to this email directly or view it on GitHub
#1219.

@theggelund
Copy link
Author

@forki forki added the bug label Nov 13, 2015
@forki forki closed this as completed in 5be086f Nov 13, 2015
@forki
Copy link
Member

forki commented Nov 13, 2015

does this work for you?

@theggelund
Copy link
Author

It worked in the test project and in some of my real projects but not all. I will try to analyze the ones that didn't work and try to create a new test project for you.

@forki forki reopened this Nov 13, 2015
@theggelund
Copy link
Author

Updated https://github.com/theggelund/paket_bug

When nuget package is sorted after MultiTarget package => nunit
the import statement comes before nunit import

And I still have the initial issue with some projects.

@theggelund
Copy link
Author

Updated https://github.com/theggelund/paket_bug

Added a project called manual_project under MyClassLibrary. The initial issue is reproduced with the project. Used latest released paket 2.24.7

@forki forki closed this as completed in a65a218 Nov 13, 2015
@forki forki reopened this Nov 13, 2015
@forki
Copy link
Member

forki commented Nov 13, 2015

ok I fixed that Nunit issue

@forki forki closed this as completed in 6e3792f Nov 13, 2015
@forki
Copy link
Member

forki commented Nov 13, 2015

I hope it's not completely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants