Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages framework restriction are propagated incorrectly #1213

Closed
vbfox opened this issue Nov 12, 2015 · 3 comments
Closed

Packages framework restriction are propagated incorrectly #1213

vbfox opened this issue Nov 12, 2015 · 3 comments
Labels
bug

Comments

@vbfox
Copy link
Contributor

vbfox commented Nov 12, 2015

Using this paket.dependencies file :

framework: >= net40

source https://nuget.org/api/v2

nuget Newtonsoft.Json redirects: on
nuget Nancy.Serialization.JsonNet ~> 1.2 framework: >= net451

The resulting lock file is :

FRAMEWORK: >= NET40
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Nancy (1.4.1) - framework: >= net451
    Nancy.Serialization.JsonNet (1.4.1) - framework: >= net451
      Nancy (>= 1.4.1)
      Newtonsoft.Json
    Newtonsoft.Json (7.0.1) - redirects: on, framework: >= net451

But the Newtonsoft.Json (7.0.1) - redirects: on, framework: >= net451 line is incorrect as the configuration intended for Newtonsoft.Json to be usable in framework: >= net40.

It seem that the framework restriction applied to Nancy.Serialization.JsonNet has unexpectedly propagated to one of it's dependencies.
@forki forki added the bug label Nov 12, 2015
@vbfox
Copy link
Contributor Author

vbfox commented Nov 12, 2015

First version with the bug seem to be 2.21.3 so it would point to #1190

@forki forki closed this as completed in db35ffc Nov 12, 2015
@forki
Copy link
Member

forki commented Nov 12, 2015

I'm very happy that we now have the integration test infrastructure in place. this one was really nasty and had a big chance to be regression to #1190. Anyways I think it's fixed. And I added your case as regression test.

@vbfox
Copy link
Contributor Author

vbfox commented Nov 12, 2015

👍

Perfect, we can now update to the latest version.

Thanks a lot.

@csmager csmager mentioned this issue May 31, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @vbfox