-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing transitive dependencies after paket update #1190
Comments
cc: @kolektiv |
Cc @mrinaldi |
I can reproduce and the error and I understand the issue. hope to provide a fix soon. |
Please retry with latest
|
Just tried the paket update repro and that now doesn't cause a problem. It does change the dependency slightly, but only by a slight expansion of the supported frameworks. A quick glance at xunit and the dependency tree makes me think it's right, which means that if anything I'm guessing this is slightly more correct than before! For the case we discovered this on, it is certainly no longer broken :) Fantastic work, thanks @forki - and @neoeinstein for tracking it down and reporting! |
Reproduction case:
paket.exe add nuget xunit project myproject.tests
xunit.abstractions
is not in the list of referencesThis can also be reproduced by taking an existing project with current xunit references and then running a
paket update
.The relevant diff after performing an update in one of my own projects:
I've determined that the issue was introduced in 2.19.0. The issue was not present in 2.18.0. Likely PR (unconfirmed) was #1174.
The text was updated successfully, but these errors were encountered: