Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"-prerelease" in .nuspec breaks paket update etc. #1099

Closed
allykzam opened this issue Sep 29, 2015 · 7 comments
Closed

"-prerelease" in .nuspec breaks paket update etc. #1099

allykzam opened this issue Sep 29, 2015 · 7 comments
Labels
bug

Comments

@allykzam
Copy link
Contributor

After building a project and distributing the new package today, noticed that paket update fails when updating a package that depends on a pre-release package. Calling the three packages "A", "B", and "C", "A" and "B" are in the same solution and now at version 0.33.0-beta; "B" depends on "A", and this is specified as a project-dependency in the project file. Project "C" depends on "B" only.

Output of paket update looks like this:

Error in resolution.
  Resolved:
   - FSharp.Core 4.0.0.1
   - Project_B 0.33.0-beta
  Could not resolve package Project_A:
   - Project_B 0.33.0-beta requested >= 0.33.0-beta-prerelease
 Please try to relax some conditions.

After some quick testing, it looks like some part of the changes for #1088 added this -prerelease suffix to the end of project B's version requirement for project A, rather than leaving it as requiring 0.33.0-beta. Assuming that this new suffix is intended to be there, I'm not sure whether this is considered an issue in how paket pack is naming my packages, how it's creating the .nuspec file, or in how dependency resolution is finding the required packages.
@forki
Copy link
Member

forki commented Sep 29, 2015

"0.33.0-beta-prerelease" is not correct syntax. so I messed that up.

@forki forki added the bug label Sep 29, 2015
@forki forki closed this as completed in 030eabc Sep 29, 2015
@forki
Copy link
Member

forki commented Sep 29, 2015

so I fixed that in 2.5. - but you have to pack the package with the broken "0.33.0-beta-prerelease" in the nuspec again. sorry about that

@allykzam
Copy link
Contributor Author

Thanks! I'll have to dig around and see how many things I've built since 2.4.8 got released, but it shouldn't be too many.

@allykzam
Copy link
Contributor Author

Sorry I didn't notice this before, but continuing to dig around, paket 2.5.0 is still adding -prerelease on the end of another dependency. It's a "transient" dependency on version 4.3.1 of a package is specified as (4.3.1) in the lock file, and it's showing up as 4.3.1-prerelease in the .nuspec file. This line makes it look like this is intentional? It looks like if I add it back into the dependencies file (paket simplify removed it for me a while ago), the .nuspec file goes back to just 4.3.1.

forki added a commit that referenced this issue Sep 29, 2015
@forki
Do not create prerelease identifiers for transitive dependencies - fixes
4be3f6f 
 #1099
@forki
Copy link
Member

forki commented Sep 29, 2015

fixed that too. please try 2.5.1

@allykzam
Copy link
Contributor Author

Now showing in the nuspec file as [4.3.1] 👍

I'll try not to complain again for at least a few more hours 😉

@forki
Copy link
Member

forki commented Sep 29, 2015

It's good to have that fixed. Thanks for reporting
On Sep 29, 2015 21:32, "Anthony Perez" [email protected] wrote:

Now showing in the nuspec file as [4.3.1] [image: 👍]

I'll try not to complain again for at least a few more hours [image:
😉]

—
Reply to this email directly or view it on GitHub
#1099 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @allykzam