Problem: rkt-tests: Fails because cantor and guiv2 require gui #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the test runner. Instead of adding them to the exclusion list, accept that only 10 of our rkt files contain tests. Solution: Test only files that declare a test submodule. As a bonus, this drastically cuts down testing time. Racket takes a very long time (20 s -- 30 s) just to load a file, only to find out there are no tests. This is now done on 10 files instead of 172 files. Grepping for 'module test' is not a generic way of finding tests, but it works on our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the test runner.
Instead of adding them to the exclusion list, accept that only 10 of
our rkt files contain tests.
Solution: Test only files that declare a test submodule.
As a bonus, this drastically cuts down testing time. Racket takes a
very long time (20 s -- 30 s) just to load a file, only to find out
there are no tests. This is now done on 10 files instead of 172 files.
Grepping for 'module test' is not a generic way of finding tests, but
it works on our code.