replace keccakf1600 - with significant performance improvements for ref #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you split this PR in two halves, I think I can manage to do the proof for the REF implementation (while postponing the proof for the AVX2 version). |
|
Well, no longer sure about my previous statement… |
vbgl
force-pushed
the
replace_keccakf
branch
from
acee459
to
e4a0d24
Compare
|
I’m done fixing the proofs. I’ve removed a few redundant instructions. |
… one in ref and avx2 (some extra spills were needed) Co-authored-by: Vincent Laporte <[email protected]>
Closed
vbgl
force-pushed
the
replace_keccakf
branch
from
e4a0d24
to
82d5ba7
Compare
vbgl
approved these changes
Feb 20, 2024
|
Hi Vincent, thank you for pushing on this. Do you think it is ready to be merged? |
|
Yes it is, if you don’t complain about the changes I’ve made to the code. |
tfaoliveira
added a commit
to formosa-crypto/libjade
that referenced
this pull request
Feb 21, 2024
|
I don't complain. At some point, maybe during the next retreat, I would like to discuss compiler warnings with you and the compiler team. |
|
Thanks. There was no need to squash the three changes into a single commit. |
Rixxc
pushed a commit
to formosa-crypto/libjade
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparison basis (left side): https://github.com/formosa-crypto/libjade/tree/bb8569c01597338148800210de5aa2b512f783c6
new cycles for ref: formosa-crypto/libjade@b53d837
new cycles avx2: formosa-crypto/libjade@7046ee9
ref
avx2