Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load segment modal UI fix #2065

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: load segment modal UI fix #2065

merged 1 commit into from
Feb 13, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Feb 13, 2024 10:19am
formbricks-com ⬜️ Ignored (Inspect) Feb 13, 2024 10:19am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

packages/ee/advancedTargeting/components/AdvancedTargetingCard.tsx

The AdvancedTargetingCard component is quite large and complex. It would be beneficial to break it down into smaller, more manageable components. This would make the code easier to read and maintain.
Create Issue
See the diff
Checkout the fix

    // Break down the AdvancedTargetingCard component into smaller components
    // For example, you could create a separate component for the SegmentEditor
    const SegmentEditorComponent = ({...props}) => {
      // SegmentEditor logic here
    }

    // Then use this new component in the AdvancedTargetingCard
    const AdvancedTargetingCard = ({...props}) => {
      // AdvancedTargetingCard logic here

      return (
        <div>
          {/* Other components */}
          <SegmentEditorComponent {...props} />
          {/* Other components */}
        </div>
      )
    }
git fetch origin && git checkout -b ReviewBot/Impro-zuwzsa7 origin/ReviewBot/Impro-zuwzsa7

packages/database/migrations/20240207041922_advanced_targeting/data-migration.ts

Consider breaking down the main function into smaller, more manageable functions. This will make the code easier to read and maintain. For example, the logic for creating filters could be moved to a separate function.
Create Issue
See the diff
Checkout the fix

    function createFilter(filter, idx) {
      const { attributeClass } = filter;
      let resource: TSegmentAttributeFilter | TSegmentPersonFilter;
      if (attributeClass.name === "userId" && attributeClass.type === "automatic") {
        resource = {
          id: createId(),
          root: {
            type: "person",
            personIdentifier: "userId",
          },
          qualifier: {
            operator: filter.condition,
          },
          value: filter.value,
        };
      } else {
        resource = {
          id: createId(),
          root: {
            type: "attribute",
            attributeClassName: attributeClass.name,
          },
          qualifier: {
            operator: filter.condition,
          },
          value: filter.value,
        };
      }

      const attributeSegment: TBaseFilter = {
        id: filter.id,
        connector: idx === 0 ? null : "and",
        resource,
      };

      return attributeSegment;
    }
git fetch origin && git checkout -b ReviewBot/Impro-82iobkd origin/ReviewBot/Impro-82iobkd

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg thanks a lot for the fix 😊🚀
(Please remember to fill out the PR description template properly 😉)

@mattinannt mattinannt added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 10b61be Feb 13, 2024
15 checks passed
@mattinannt mattinannt deleted the fix/targeting-fixes branch February 13, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants