Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group events by environmentId in posthog #2036

Merged
merged 6 commits into from
Feb 12, 2024
Merged

feat: group events by environmentId in posthog #2036

merged 6 commits into from
Feb 12, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Group Events by Environment ID in Posthog (we did this before with the teamId but that does not seem to reflect in Posthog so this is another attempt at making it work 🤞🏼)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:12am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:12am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@ShubhamPalriwala
Copy link
Contributor Author

This fixes why the groups weren't visible in our dashboard! However, this also increases the calls we make to Posthog another 1x hence double the calls! Have asked the Posthog team for a better solution here: PostHog/posthog#7746 (comment) which we can incorporate once they get back

mattinannt
mattinannt approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks a lot for the last changes; this makes everything much cleaner 😊🚀
I also removed the teamDetails service since this now isn't used anymore.
You also made some changes in the pages directory endpoints that they are using services. This unfortunately leads to errors since some things aren't working in the pages directory as it's working in the app directory (e.g. the server-only package).

I checked our server logs and saw that it's save to remove the whole pages folder since the endpoints are no longer used.

Let's get this merged! 💪🚀

@mattinannt mattinannt added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 14b162a Feb 12, 2024
13 checks passed
@mattinannt mattinannt deleted the shubham/for-1631-add-teams-to-posthog-cloud branch February 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
💬 discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamPalriwala @mattinannt