-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Delete tags not working once merge operation is completed. #2886
Comments
I am willing to pick this up and work on it! |
Hey @vaishak10 , I am not able to reproduce this issue in Mac. It works fine. Screen.Recording.2024-07-16.at.1.16.45.AM.mov |
Hey @vaishak10 , merging and deletion of tags seems to work well for me too, but one thing that i noticed here is the confirmation modal. In our app we use this Delete Dialog modal (you can find it in ![]() But that seems to be missing for tag deletion ![]() If you like, you can open a PR fixing that 😊🙌🏻 |
@smritidoneria I faced this issue multiple times. in some cases the merge was successful but on working with tags multiple times started seeing this behaviour. Try with adding multiple tags and try merging tags one after another |
Issue Summary
So I created 6 tags, and merged the first tag with the 6th tag. In this process found some issues I wanted to bring up:
tag1
is merged withtag6
then onlytag6
should be visible.tag1
is visible after merge why is there a delete and merge button next to the tag. As far as I have understood the tag should not have these buttons after merge. The main issue what we face here is even if the user tries to delete the tag it won't be deleted. Only the tag it was merged with can be deleted.My fix will be is to remove the tag from the UI once it's merged then all these issues won't be reproducible.
Preview
Screen.Recording.2024-07-13.at.9.mp4
Steps to Reproduce
Expected behavior
Once a tag is merge it should not be visible in the UI. The user should not be able to delete or merge the tag again
Other information
No response
Screenshots
No response
Environment
Desktop (please complete the following information)
The text was updated successfully, but these errors were encountered: