Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Delete tags not working once merge operation is completed. #2886

Closed
1 of 2 tasks
vaishak10 opened this issue Jul 13, 2024 · 5 comments
Closed
1 of 2 tasks

[BUG] Delete tags not working once merge operation is completed. #2886

vaishak10 opened this issue Jul 13, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@vaishak10
Copy link
Contributor

Issue Summary

So I created 6 tags, and merged the first tag with the 6th tag. In this process found some issues I wanted to bring up:

  1. Once a tag is merged then why is it still being visible in the UI. What I mean is if tag1 is merged with tag6 then only tag6 should be visible.
  2. Even if tag1 is visible after merge why is there a delete and merge button next to the tag. As far as I have understood the tag should not have these buttons after merge. The main issue what we face here is even if the user tries to delete the tag it won't be deleted. Only the tag it was merged with can be deleted.
  3. Also the toast message needs to updated and needs to send a better message if merge is done again.

My fix will be is to remove the tag from the UI once it's merged then all these issues won't be reproducible.

Preview

Screen.Recording.2024-07-13.at.9.mp4

Steps to Reproduce

  1. Add multiple tags for a response.
  2. Edit tags -> Merge one tag with another.
  3. Delete a tag once merged or merge the same tag with another tag or same tag again

Expected behavior

Once a tag is merge it should not be visible in the UI. The user should not be able to delete or merge the tag again

Other information

No response

Screenshots

No response

Environment

  • Formbricks Cloud (app.formbricks.com)
  • Self-hosted Formbricks

Desktop (please complete the following information)

- OS: MacOS
- Node:
- npm:
@vaishak10 vaishak10 added the bug Something isn't working label Jul 13, 2024
@vaishak10
Copy link
Contributor Author

I am willing to pick this up and work on it!

@smritidoneria
Copy link
Contributor

Hey @vaishak10 , I am not able to reproduce this issue in Mac. It works fine.
Kindly Check this out-

Screen.Recording.2024-07-16.at.1.16.45.AM.mov

@Dhruwang
Copy link
Contributor

Hey @vaishak10 , merging and deletion of tags seems to work well for me too, but one thing that i noticed here is the confirmation modal. In our app we use this Delete Dialog modal (you can find it in packages/ui/DeleteDialog)

Screenshot 2024-07-16 at 10 41 40 AM

But that seems to be missing for tag deletion

Screenshot 2024-07-16 at 10 39 32 AM

If you like, you can open a PR fixing that 😊🙌🏻

@vaishak10
Copy link
Contributor Author

vaishak10 commented Jul 17, 2024

Hey @vaishak10 , I am not able to reproduce this issue in Mac. It works fine. Kindly Check this out-

Screen.Recording.2024-07-16.at.1.16.45.AM.mov

@smritidoneria I faced this issue multiple times. in some cases the merge was successful but on working with tags multiple times started seeing this behaviour. Try with adding multiple tags and try merging tags one after another

@vaishak10
Copy link
Contributor Author

Hey @Dhruwang have raised the PR for the fix: #2912
Please do review it if any changes are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants