Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to sprockets 4.0.0 #6172

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Bump to sprockets 4.0.0 #6172

merged 4 commits into from
Feb 24, 2020

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Feb 19, 2020 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR upgrades sprockets from 3.7.2 to 4.0.0, see changelog

The main new features are:

    Source Maps
    Manifest.js
    ES6 support
    Deprecated processor interface in 3.x is removed in 4.x

This is the upgrade guide: https://github.com/rails/sprockets/blob/master/UPGRADING.md

I also generated a new Rails 5.2 app and double checked the configuration.

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Feb 19, 2020
@maestromac maestromac mentioned this pull request Feb 19, 2020
Closed
@rhymes
Copy link
Contributor Author

rhymes commented Feb 20, 2020

I think CodeClimate started flagging all these errors we have been ignoring in app/assets/javascripts so far ;-) https://codeclimate.com/github/thepracticaldev/dev.to/pull/6172

@rhymes rhymes marked this pull request as ready for review February 20, 2020 09:59
@rhymes rhymes requested a review from a team as a code owner February 20, 2020 09:59
@rhymes rhymes requested review from a team, citizen428 and maestromac and removed request for a team February 20, 2020 09:59
@rhymes rhymes added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Feb 20, 2020
@mstruve mstruve removed the request for review from a team February 20, 2020 17:02
citizen428
citizen428 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @rhymes 👏

maestromac
maestromac approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally. LGTM!!

@maestromac maestromac merged commit c3e7179 into forem:master Feb 24, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Feb 24, 2020
@rhymes rhymes deleted the rhymes/upgrade-sprockets-400 branch February 25, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@maestromac maestromac maestromac approved these changes

@nickytonline nickytonline Awaiting requested review from nickytonline

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhymes @citizen428 @maestromac