-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Subsets for Custom Packager #730
Comments
Is this why ext fonts doesn't render properly at all? For example, courier prime But the I noticed when testing on https://fontsource.org/fonts/courier-prime that it doesn't load the ext font att all when choosing it from the dropdown, it's still showing latin. Update: Seems all ext fonts are broken |
@tmikaeld, that is intentional. Usually our CSS files include both and the I suppose our subsets documentation could be improved to make that distinction clearer. |
Right, so both latin and latin-ext should be loaded. Does this apply to any other subsets? |
It applies to all other subsets. They only support their specific range of characters and you need to combine them with The only case this does not apply is non-Google fonts where our custom packager for that does not support subsetting and therefore every subset is usually included in one file. |
I'll move to a discussion instead of polluting this issue. |
Description
The current custom packager only defaults to subset
latin
since it has no information on what subsets a given font may support. Therefore, we can't give it properunicode-range
values either. We should have a preprocessor that determines what subsets the font supports and split it accordingly matching how Google does it.The text was updated successfully, but these errors were encountered: