Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Squash docker layers after building #247

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Squash docker layers after building #247

wants to merge 1 commit into from

Conversation

zootalures
Copy link
Member

@zootalures zootalures commented Feb 10, 2021 •
edited

This is a quick POC to demonstrate doing docker-daemon level image squashing
This will change the behaviour of image pulls so should be reviewed w.r.t. actual system performance before merging.

@shaunsmith
Copy link
Contributor

Two issues @owencliffe. The native images don't pass on the build script args to the docker build command so passing "--squash" won't have any effect. The build-native script expects the first arg to be the runtime dir. You've made the first arg "--squash" which will result in failure.

I've got a PR to update the native image builds pending: #246

@zootalures zootalures force-pushed the oc/squashRuntimeLayers branch 2 times, most recently from d21e446 to 9f3ad42 Compare February 11, 2021 12:03
astromechza
astromechza approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. although not sure how to build these locally to verify. the ./build.sh script gets stuck on a test somewhere

@zootalures zootalures changed the title Squash docker layers after building WIP: Squash docker layers after building Feb 12, 2021
@zootalures zootalures marked this pull request as draft February 12, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zootalures @shaunsmith @astromechza