Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run validate manifests action as non-root user #35

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

bsord
Copy link
Contributor

@bsord bsord commented Jul 28, 2021

The validate manifests action docker container currently runs as root which goes against security best practices for containers. User 1001 provides the necessary elevated privileges to run what's needed by github/azure/etc while not running the container directly as root. This PR would resolve Issue 34

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bsord

@stefanprodan stefanprodan merged commit 36ad4e3 into fluxcd:main Jul 28, 2021
kingdonb pushed a commit to kingdonb/flux2-multi-tenancy that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest validation github action container runs as root user
2 participants